Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of adding contributing.md to each adapter repo #276

Merged
merged 7 commits into from
Jun 1, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jan 20, 2022

resolves #

No issue currently

Description

Adding contributing.md files to each adapter

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

Copy link

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tweaks, thanks for adding this to this repo

CONTRIBUTING.MD Outdated Show resolved Hide resolved
CONTRIBUTING.MD Outdated Show resolved Hide resolved
CONTRIBUTING.MD Outdated Show resolved Hide resolved
CONTRIBUTING.MD Outdated Show resolved Hide resolved
CONTRIBUTING.MD Outdated Show resolved Hide resolved
@McKnight-42 McKnight-42 requested a review from kwigley February 9, 2022 15:59
@kwigley
Copy link

kwigley commented Feb 11, 2022

I think we need a test.env.example for this repository, should we do that as part of this PR @McKnight-42?

@McKnight-42
Copy link
Contributor Author

I think we need a test.env.example for this repository, should we do that as part of this PR @McKnight-42?

@kwigley I will look into getting that going thanks for pointing out it not being their, does it being in CircleCI and not GHA change anything? i think this is one of the only ones still over there.

@kwigley
Copy link

kwigley commented Feb 22, 2022

@McKnight-42 the test.env file is only used for testing locally, secrets for CircleCI and GHA are stored in those services. the test.env.example file can look like what is does for other database adapters to enable running integration tests locally 👍

@McKnight-42 McKnight-42 self-assigned this Mar 18, 2022
CONTRIBUTING.MD Show resolved Hide resolved
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM too but I would say make sure the changes you make in the Redshift file, you also make here

@leahwicz
Copy link
Contributor

@McKnight-42 if the tests keep failing, it's ok to merge this one since this isn't a code change and instead flaky tests

@McKnight-42 McKnight-42 merged commit bc9fc0b into main Jun 1, 2022
@McKnight-42 McKnight-42 deleted the McKnight-42/contributing branch June 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants