-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of adding contributing.md to each adapter repo #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tweaks, thanks for adding this to this repo
… and CI as spark still uses CircleCI and not GHA
I think we need a |
@kwigley I will look into getting that going thanks for pointing out it not being their, does it being in CircleCI and not GHA change anything? i think this is one of the only ones still over there. |
@McKnight-42 the test.env file is only used for testing locally, secrets for CircleCI and GHA are stored in those services. the test.env.example file can look like what is does for other database adapters to enable running integration tests locally 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM too but I would say make sure the changes you make in the Redshift file, you also make here
@McKnight-42 if the tests keep failing, it's ok to merge this one since this isn't a code change and instead flaky tests |
resolves #
No issue currently
Description
Adding contributing.md files to each adapter
Checklist
CHANGELOG.md
and added information about my change to the "dbt-spark next" section.