init pr push for ct-1005 #418
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-core contributing guide, and the dbt-spark contriubuting guide. |
.github/pull_request_template.md
Outdated
| @@ -18,4 +18,4 @@ resolves # | |||
| - [ ] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) | |||
| - [ ] I have run this code in development and it appears to resolve the stated issue | |||
| - [ ] This PR includes tests, or tests are not required/relevant for this PR | |||
| - [ ] I have updated the `CHANGELOG.md` and added information about my change to the "dbt-spark next" section. | |||
| - [ ] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md#Adding-CHANGELOG-Entry) | |||
There was a problem hiding this comment.
Since you're updating the contributing doc with this info, should this point to the dbt-spark contributing doc instead?
There was a problem hiding this comment.
oh good catch will have to fix that on the others as well was still using the core contributing guide as main source since we generally try to send all like information there and just point to it as the source of truth but we are adding the small section in this case. will fix in other repos as well as needed1
| changelog: | ||
| uses: dbt-labs/actions/.github/workflows/changelog-existence.yml@main | ||
| with: | ||
| changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see [the dbt-core contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md#adding-changelog-entry), and the [dbt-spark contriubuting guide](https://github.com/dbt-labs/dbt-spark/blob/main/CONTRIBUTING.MD).' |
There was a problem hiding this comment.
Same comment here with pointing to the dbt-spark contributing section.
There was a problem hiding this comment.
so for here we just want to remove the ref to core instead of both?
There was a problem hiding this comment.
What's the value in linking to both?
There was a problem hiding this comment.
None in this case removing.
| changelog: | ||
| uses: dbt-labs/actions/.github/workflows/changelog-existence.yml@main | ||
| with: | ||
| changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the [dbt-spark contriubuting guide](https://github.com/dbt-labs/dbt-spark/blob/main/CONTRIBUTING.MD).' |
There was a problem hiding this comment.
| changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the [dbt-spark contriubuting guide](https://github.com/dbt-labs/dbt-spark/blob/main/CONTRIBUTING.MD).' | |
| changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the [dbt-spark contributing guide](https://github.com/dbt-labs/dbt-spark/blob/main/CONTRIBUTING.MD).' |
There was a problem hiding this comment.
fixed also changed ref to the adapter instead of core in .changes README.md
…ISSUE ref to spark issue #417
resolves #416
Description
Add
changietodbt-sparkChecklist
CHANGELOG.mdand added information about my change to the "dbt-spark next" section.