-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate timestamp macros #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
6 tasks
…abs/dbt-spark into consolidateTimestampMacros
retrying circle CI tests, running locally tests pass |
dbeatty10
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
* add mypy ignore to column, connections and init * consolidate timestamp macros * add changie * Update Features-20220926-123609.yaml * add backcompat to test fixture * remove current_timestamp_in_utc * add expected_sql * remove backcompat from test_timestamps.py * update dev-requirements * Update change log body * lower case timestamps (cherry picked from commit b65e4f3)
leahwicz
pushed a commit
that referenced
this pull request
Oct 3, 2022
* add mypy ignore to column, connections and init * consolidate timestamp macros * add changie * Update Features-20220926-123609.yaml * add backcompat to test fixture * remove current_timestamp_in_utc * add expected_sql * remove backcompat from test_timestamps.py * update dev-requirements * Update change log body * lower case timestamps (cherry picked from commit b65e4f3) Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Oct 3, 2022
### Description Adds a test for "consolidate timestamp macros" at dbt-labs/dbt-spark#480.
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Oct 3, 2022
### Description Adds a test for "consolidate timestamp macros" at dbt-labs/dbt-spark#480.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #483
Description
Checklist
changie new
to create a changelog entry