Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate timestamp macros #480

Merged
merged 17 commits into from
Oct 3, 2022
Merged

consolidate timestamp macros #480

merged 17 commits into from
Oct 3, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 26, 2022

resolves #483

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@colin-rogers-dbt
Copy link
Contributor Author

retrying circle CI tests, running locally tests pass

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leahwicz leahwicz merged commit b65e4f3 into main Oct 3, 2022
@leahwicz leahwicz deleted the consolidateTimestampMacros branch October 3, 2022 15:04
github-actions bot pushed a commit that referenced this pull request Oct 3, 2022
* add mypy ignore to column, connections and init

* consolidate timestamp macros

* add changie

* Update Features-20220926-123609.yaml

* add backcompat to test fixture

* remove current_timestamp_in_utc

* add expected_sql

* remove backcompat from test_timestamps.py

* update dev-requirements

* Update change log body

* lower case timestamps

(cherry picked from commit b65e4f3)
leahwicz pushed a commit that referenced this pull request Oct 3, 2022
* add mypy ignore to column, connections and init

* consolidate timestamp macros

* add changie

* Update Features-20220926-123609.yaml

* add backcompat to test fixture

* remove current_timestamp_in_utc

* add expected_sql

* remove backcompat from test_timestamps.py

* update dev-requirements

* Update change log body

* lower case timestamps

(cherry picked from commit b65e4f3)

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Oct 3, 2022
### Description

Adds a test for "consolidate timestamp macros" at dbt-labs/dbt-spark#480.
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Oct 3, 2022
### Description

Adds a test for "consolidate timestamp macros" at dbt-labs/dbt-spark#480.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1246] [Feature] Consolidate current_timestamp & associates
3 participants