trying to fix tox issue causing failures #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
|
Question? how far up would we want to upgrade the python version? any preferences here? |
|
I think 3.8+ is reasonable. 3.7 is being dropped by many projects. I would also include 3.10: https://github.com/dbt-labs/dbt-spark/blob/main/setup.py#L93 Python 3.11 has been released recently but hasn't been adopted widely by downstream dependencies, so that might be a bit challenging. |
|
Since we're not quite at 3.7's EOL date I'd suggest we keep it for now |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
* updating tox python version, changing contriburing file example for integration tests * remove change to contributing file for backport ease * add changelog * trying to incorprorate mulit python version * trying to fix unit test * remove unneded call to basepython * back to 3.8 (cherry picked from commit 9511847)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-534-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 951184703a3d95656b9796033503789bdfa01ce8
# Push it to GitHub
git push --set-upstream origin backport-534-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latestThen, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
* updating tox python version, changing contriburing file example for integration tests * remove change to contributing file for backport ease * add changelog * trying to incorprorate mulit python version * trying to fix unit test * remove unneded call to basepython * back to 3.8 (cherry picked from commit 9511847)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-534-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 951184703a3d95656b9796033503789bdfa01ce8
# Push it to GitHub
git push --set-upstream origin backport-534-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latestThen, create a pull request where the |
McKnight-42
added a commit
that referenced
this pull request
Dec 5, 2022
6 tasks
McKnight-42
added a commit
that referenced
this pull request
Dec 6, 2022
* manual backport of pr #534 to 1.1.latest * Update setup.py Co-authored-by: Fokko Driesprong <fokko@apache.org> * mirror python bound for dbt-core Co-authored-by: Florian Eiden <florian.eiden@fleid.fr> Co-authored-by: Fokko Driesprong <fokko@apache.org>
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Dec 9, 2022
* trying to fix tox issue causing failures (#534) * updating tox python version, changing contriburing file example for integration tests * remove change to contributing file for backport ease * add changelog * trying to incorprorate mulit python version * trying to fix unit test * remove unneded call to basepython * back to 3.8 (cherry picked from commit 9511847) * trying to add a allowlist_externals clause for /bin/bash in tox * formatting fix * formatting fix * formatting fix * trying to tie allowlist to specific test Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Dec 9, 2022
* trying to fix tox issue causing failures (#534) * updating tox python version, changing contriburing file example for integration tests * remove change to contributing file for backport ease * add changelog * trying to incorprorate mulit python version * trying to fix unit test * remove unneded call to basepython * back to 3.8 (cherry picked from commit 9511847) * created allowlist_externals part for unit test * adding allowlist to spark-session Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #536
Description
errors in workflow caused by old python version
Checklist
changie newto create a changelog entry