Policy Changes to support Py 3.11 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
colin-rogers-dbt
commented
Dec 9, 2022
| @@ -171,7 +171,7 @@ def list_relations_without_caching( | |||
| return relations | |||
|
|
|||
| def get_relation(self, database: str, schema: str, identifier: str) -> Optional[BaseRelation]: | |||
| if not self.Relation.include_policy.database: | |||
| if not self.Relation.get_default_include_policy().database: | |||
There was a problem hiding this comment.
@ChenyuLInx does this still make sense? Just looping you in for python models impact sanity check
There was a problem hiding this comment.
I am not familiar with include_policy, but as long as the relations are still the same, I think it won't affect python models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #542
Description
Checklist
changie newto create a changelog entry