Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing schema in catalog for delta tables #589

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hanna-liashchuk
Copy link
Contributor

@hanna-liashchuk hanna-liashchuk commented Jan 12, 2023

resolves #368, #295

Description

Delta tables do not return schema information in SHOW TABLE EXTENDED in {{ relation }} like '*';
This PR uses describe extended {{ relation }}; if the table has delta provider.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • tests are not required/relevant for this PR
  • docs changes are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Jan 12, 2023
@hanna-liashchuk hanna-liashchuk force-pushed the fix-source-generation-for-delta branch from 140301b to cb701b3 Compare January 12, 2023 17:34
@hanna-liashchuk hanna-liashchuk force-pushed the fix-source-generation-for-delta branch from cb701b3 to fd1d6a8 Compare January 12, 2023 17:35
@VShkaberda
Copy link
Contributor

VShkaberda commented Jan 18, 2023

@jtcohen6 This solution resolves #368 which seems to be opensource deltalake problem, but will also affect those, who work with Databricks. Is this viable?

@hanna-liashchuk
Copy link
Contributor Author

@VShkaberda should not affect the databricks users, since describe extended works for Databricks too

@nathaniel-may nathaniel-may requested a review from a team as a code owner March 16, 2023 21:20
@nathaniel-may nathaniel-may requested a review from Fleid March 16, 2023 21:20
@Fleid Fleid added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Apr 4, 2023
@Fleid
Copy link
Contributor

Fleid commented Apr 4, 2023

We will try to land this in 1.5.0 but my confidence is low (just too much to be done before then).

Copy link
Contributor

github-actions bot commented Aug 6, 2024

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-725] [CT-630] Sources are not passed into catalog.json
5 participants