support contracts on models materialized as view #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of dbt-labs/dbt-core#7120 |
emmyoop
requested review from
colin-rogers-dbt,
nssalian and
mikealfare
and removed request for
colin-rogers-dbt and
nssalian
mikealfare
reviewed
Mar 8, 2023
| create temporary view {{ relation }} as | ||
| create temporary view {{ relation }} | ||
| {% if config.get('contract', False) -%} | ||
| {{ get_assert_columns_equivalent(sql) }} |
There was a problem hiding this comment.
The argument coming in is compiled_code whereas sql is getting passed in here. Is that correct?
There was a problem hiding this comment.
Good catch. I dug in here because of concern for python models (not currently supported) and this code is only hit for incremental models that already exist as tables. dbt-labs/dbt-core#6755 is the task to make sure those cases are covered so I'm removing this logic as it does not directly relate to models materialized specifically as view.
mikealfare
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #654
Description
Support contracts for view materializations.
Checklist
changie newto create a changelog entry