Pass existing server_side_parameters to session connection wrapper and use to configure SparkSession. #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d use to configure SparkSession.
Fokko
reviewed
May 15, 2023
dbt/adapters/spark/connections.py
Outdated
| @@ -449,7 +449,7 @@ def open(cls, connection): | |||
| SessionConnectionWrapper, | |||
| ) | |||
|
|
|||
| handle = SessionConnectionWrapper(Connection()) | |||
| handle = SessionConnectionWrapper(Connection(), creds.server_side_parameters) | |||
There was a problem hiding this comment.
I would rather pass this in the Connection constructor.
Suggested change
| handle = SessionConnectionWrapper(Connection(), creds.server_side_parameters) | |
| handle = SessionConnectionWrapper(Connection(creds.server_side_parameters)) |
And then the connection can pass it down to the constructor of the Cursor. The config doesn't change between .execute() calls, so I think it makes more sense to pass it in the constructors.
There was a problem hiding this comment.
@Fokko I haven't tested this, but is the new code what you had in mind?
There was a problem hiding this comment.
@alarocca-apixio That's exactly what I had in mind, thanks!
Fokko
approved these changes
May 17, 2023
There was a problem hiding this comment.
I just gave this a swing locally, and it works like a charm! Thanks @alarocca-apixio for picking this up
dataders
added
ok_to_test
ready_for_review
6 tasks
|
Prefer PR #823 823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #690
Description
Pass existing server_side_parameters to session connection wrapper and use to configure SparkSession.
Checklist
changie newto create a changelog entry