-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbt_clone macros, materialization and tests to dbt-spark #816
Conversation
testing update 6/29: passing |
@jtcohen6 Curious I know we want the |
@McKnight-42 IMO no need to support |
{%- if file_format != 'delta' -%} | ||
{% set invalid_format_msg -%} | ||
Invalid file format: {{ file_format }} | ||
shallow clone requires file_format be set to 'delta' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, why can't we do this with non-delta formats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be a misunderstanding on my part honestly will double check I know our writeup and the docs for Databricks specifies delta tables
might of confused that with our delta format suggestion, we use in some other places
I know dbt-databricks
uses delta tables by default but I don't believe dbt-spark
does fully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but LGTM
resolves #815
Description
adding the macros, and customer materialization needed on adapter side for dbt_clone and trying to design adapter zone version of Clone tests from defer_state in dbt-labs/dbt-core#7881
Checklist
changie new
to create a changelog entry