Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyHive pure-sasl import #818

Merged
merged 35 commits into from
Aug 21, 2023
Merged

Use PyHive pure-sasl import #818

merged 35 commits into from
Aug 21, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Jun 28, 2023

resolves #524
resolves #864

Description

Checklist

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner June 28, 2023 17:25
@colin-rogers-dbt colin-rogers-dbt requested a review from Fleid June 28, 2023 17:25
@cla-bot cla-bot bot added the cla:yes label Jun 28, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@@ -75,7 +75,6 @@ def project_from_dict(project, profile, packages=None, selectors=None, cli_vars=
project_root=project_root,
project_dict=project,
packages_dict=packages,
dependent_projects_dict={},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

setup.py Show resolved Hide resolved
dev-requirements.txt Outdated Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review August 21, 2023 16:26
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt merged commit 07383d9 into main Aug 21, 2023
@colin-rogers-dbt colin-rogers-dbt deleted the usePureSasl branch August 21, 2023 20:10
@mikealfare mikealfare mentioned this pull request Sep 27, 2023
6 tasks
Copy link
Contributor

github-actions bot commented Nov 9, 2023

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-818-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07383d906f5ab97e9f4db72926d401d45e47c2c2
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-818-to-1.6.latest.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-818-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07383d906f5ab97e9f4db72926d401d45e47c2c2
# Push it to GitHub
git push --set-upstream origin backport-818-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-818-to-1.5.latest.

mikealfare pushed a commit that referenced this pull request Nov 9, 2023
* Use PyHive pure-sasl import

* Test PyHive pure-sasl import

* update requirements.txt

* use github fix for >3.11

* use github fix for >3.11

* fix pyhive spec

* remove unnecessary requests extra

* remove unnecessary sasl install

* add changie

* specify no-binary for pyodbc install

* conditionally import sasl vs puresasl

* conditionally import sasl vs pure-sasl

* experiment with pure sasl SASLClient

* file formatting

* test using only puresasl

* test using only puresasl

* update requirements.txt

* remove sasl from req

* remove unused sys dependency

* test spark-session

* fix pure-sasl

* allow pre-release installs

* allow pre-release installs

* use pyhive 0.7.0

* add pyhive back to reqs

* fix setup.py and remove sasl from dev-requirements.txt

* Update Dependencies-20230628-121341.yaml

* remove unnecessary pip_pre arg from tox.ini

---------

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>

(cherry picked from commit 07383d9)
mikealfare pushed a commit that referenced this pull request Nov 9, 2023
* Use PyHive pure-sasl import

* Test PyHive pure-sasl import

* update requirements.txt

* use github fix for >3.11

* use github fix for >3.11

* fix pyhive spec

* remove unnecessary requests extra

* remove unnecessary sasl install

* add changie

* specify no-binary for pyodbc install

* conditionally import sasl vs puresasl

* conditionally import sasl vs pure-sasl

* experiment with pure sasl SASLClient

* file formatting

* test using only puresasl

* test using only puresasl

* update requirements.txt

* remove sasl from req

* remove unused sys dependency

* test spark-session

* fix pure-sasl

* allow pre-release installs

* allow pre-release installs

* use pyhive 0.7.0

* add pyhive back to reqs

* fix setup.py and remove sasl from dev-requirements.txt

* Update Dependencies-20230628-121341.yaml

* remove unnecessary pip_pre arg from tox.ini

---------

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>

(cherry picked from commit 07383d9)
colin-rogers-dbt added a commit that referenced this pull request Nov 9, 2023
* Use PyHive pure-sasl import

* Test PyHive pure-sasl import

* update requirements.txt

* use github fix for >3.11

* use github fix for >3.11

* fix pyhive spec

* remove unnecessary requests extra

* remove unnecessary sasl install

* add changie

* specify no-binary for pyodbc install

* conditionally import sasl vs puresasl

* conditionally import sasl vs pure-sasl

* experiment with pure sasl SASLClient

* file formatting

* test using only puresasl

* test using only puresasl

* update requirements.txt

* remove sasl from req

* remove unused sys dependency

* test spark-session

* fix pure-sasl

* allow pre-release installs

* allow pre-release installs

* use pyhive 0.7.0

* add pyhive back to reqs

* fix setup.py and remove sasl from dev-requirements.txt

* Update Dependencies-20230628-121341.yaml

* remove unnecessary pip_pre arg from tox.ini

---------

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>

(cherry picked from commit 07383d9)

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
colin-rogers-dbt added a commit that referenced this pull request Nov 9, 2023
* Use PyHive pure-sasl import

* Test PyHive pure-sasl import

* update requirements.txt

* use github fix for >3.11

* use github fix for >3.11

* fix pyhive spec

* remove unnecessary requests extra

* remove unnecessary sasl install

* add changie

* specify no-binary for pyodbc install

* conditionally import sasl vs puresasl

* conditionally import sasl vs pure-sasl

* experiment with pure sasl SASLClient

* file formatting

* test using only puresasl

* test using only puresasl

* update requirements.txt

* remove sasl from req

* remove unused sys dependency

* test spark-session

* fix pure-sasl

* allow pre-release installs

* allow pre-release installs

* use pyhive 0.7.0

* add pyhive back to reqs

* fix setup.py and remove sasl from dev-requirements.txt

* Update Dependencies-20230628-121341.yaml

* remove unnecessary pip_pre arg from tox.ini

---------

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>

(cherry picked from commit 07383d9)

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-789] [Feature] Upgrade PyHive to support Python 3.11 ADAP-56 Support Python 3.11
3 participants