Added sample_profiles.yml so that adapter works with new --adapter option of dbt init #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2020
Merged
jtcohen6
reviewed
Jun 26, 2020
There was a problem hiding this comment.
One quick thought, since dbt-spark has two distinct connection methods available:
- Should there be an additional flag for
httpversusthrift? - Should we default to
thriftinstead ofhttp, since that's how we connect to the dockerized spark that ships with this repo? Or keephttpas the default because we assume that most people are running against hosted spark (i.e. Databricks)?
|
Why not both? haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2533
Description
Added option '--adapter' to
dbt init, to create sample profiles.yml based on chosen adapter.It gets the sample profiles.yml from the adapter 'includes' folder