make union work on bq #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is blocking on the 0.11.1 release of dbt |
jtcohen6
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Everything in this PR looks good to me. A few adjacent comments that may cause failing integration tests (if/when we run circle through a BQ project):
- BQ does not accept
exceptas a lone keyword, so the equality schema test needs to useexcept distinct - The seed file
data_split_partis currently missing a comma (column) in its last row
|
Awesome, good catches @jtcohen6! I think we're actually in good shape to run integration tests on snowflake/bq/redshift these days. I'm going to merge this, but I just made an issue to track those two topics. Thanks! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: