Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review actual behavior of --lock and --upgrade for dbt deps #4481

Closed
dbeatty10 opened this issue Nov 15, 2023 · 0 comments · Fixed by #4526
Closed

Review actual behavior of --lock and --upgrade for dbt deps #4481

dbeatty10 opened this issue Nov 15, 2023 · 0 comments · Fixed by #4526
Milestone
dbt Core v1.7 Doc...

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Nov 15, 2023 •
edited
Loading

While you're on this, the doc mentions:

You can run dbt deps --lock to update the package-lock.yml with the most recent dependencies from packages

I could be wrong, but by glancing at the code, it seems to me that this is inaccurate. The correct statement should be along the lines of:

You can pass the flags:
--lock: Create or replace the lock file if it does not exist or if packages.yml has changed, and stop (do not install the packages).
--upgrade: Create or replace the lock file with the latest compatible versions, and install the packages unless the flag --lock is also passed.

Originally posted by @seub in #4470 (comment)
@dbeatty10 dbeatty10 mentioned this issue Nov 15, 2023
Merged
3 tasks
@matthewshaver matthewshaver mentioned this issue Nov 21, 2023
Merged
3 tasks
matthewshaver added a commit that referenced this issue Dec 18, 2023
@matthewshaver
Updating deps command page (#4526)
d229620 
## What are you changing in this pull request and why?

Addressing community feedback here:
https://dbt-labs.slack.com/archives/C02NCQ9483C/p1700602038744759

Closes #4481

## Checklist

- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

Updating deps command page dbt-labs/docs.getdbt.com
2 participants
@dbeatty10 @graciegoheen