Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --clean-project-files-only / --no-clean-project-files-only to 1.7 upgrade guide #4482

Closed
1 task done
dbeatty10 opened this issue Nov 15, 2023 · 1 comment · Fixed by #5121
Closed
1 task done

Add --clean-project-files-only / --no-clean-project-files-only to 1.7 upgrade guide #4482

dbeatty10 opened this issue Nov 15, 2023 · 1 comment · Fixed by #5121
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.7 Doc...

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.7

What part(s) of the page would you like to see updated?

See dbt-labs/dbt-core#9089 (comment) for context.

--clean-project-files-only / --no-clean-project-files-only
If disabled, dbt clean will delete all paths
specified in clean-paths, even if they're
outside the dbt project.

Issue: dbt-labs/dbt-core#8318
PR: dbt-labs/dbt-core#8469

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Nov 15, 2023
@dbeatty10 dbeatty10 mentioned this issue Nov 15, 2023
Closed
2 tasks
@jtcohen6 jtcohen6 added this to the dbt Core v1.7 Documentation milestone Nov 27, 2023
@jtcohen6
Copy link
Collaborator

This just came up in another dbt-core issue:

@edgarrmondragon edgarrmondragon mentioned this issue Feb 2, 2024
Open
@matthewshaver matthewshaver mentioned this issue Mar 19, 2024
Merged
7 tasks
matthewshaver added a commit that referenced this issue Mar 21, 2024
@matthewshaver
Update dbt clean in migration guide for v1.7 (#5121)
7a6a594 
## What are you changing in this pull request and why?

Closes #4482

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/vercel.json`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

Update dbt clean in migration guide for v1.7 dbt-labs/docs.getdbt.com
2 participants
@jtcohen6 @dbeatty10