Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info block on SSO config docs for single-tenant to contact support instead #3611

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Info block on SSO config docs for single-tenant to contact support instead #3611

merged 6 commits into from
Jun 26, 2023

Conversation

ajaythomas
Copy link
Contributor

@ajaythomas ajaythomas commented Jun 23, 2023 •
edited
Loading

What are you changing in this pull request and why?

SSO config docs is only usable by multiTenant. Add an info blurb to the top of the page to inform ST customers to contact support instead.

Changes here

https://dbtlabs.atlassian.net/browse/ENTERPRISE-529

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@ajaythomas ajaythomas requested a review from a team as a code owner June 23, 2023 19:54
@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 221799e
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6499c7fdc60adc0008f98234
😎 Deploy Preview https://deploy-preview-3611--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 23, 2023
@mirnawong1
Copy link
Contributor

hey @ajaythomas thanks so much for opening this up! I'm going to look at this doc for you, however, wanted to clarify if multi tenant accounts are the only ones that can use the docs for SSO SAML? or does the same ST blurb apply to the SSO with Okta, SSO with Google, etc. docs.

@ajaythomas ajaythomas force-pushed the ajay-updateSSODocsForVPC branch from 10517e4 to df45827 Compare June 26, 2023 12:31
@ajaythomas
Copy link
Contributor Author

hey @ajaythomas thanks so much for opening this up! I'm going to look at this doc for you, however, wanted to clarify if multi tenant accounts are the only ones that can use the docs for SSO SAML? or does the same ST blurb apply to the SSO with Okta, SSO with Google, etc. docs.

yes @mirnawong1. MT customers are the only ones who can use these docs for SAML, GSuite and Azure AD SSO config. Added a new commit across all SSO docs

@ajaythomas ajaythomas requested review from saimaddali and BrJan June 26, 2023 12:38
BrJan
BrJan reviewed Jun 26, 2023
View reviewed changes
website/docs/docs/cloud/manage-access/set-up-sso-azure-active-directory.md Outdated
@@ -9,6 +9,8 @@ sidebar_label: "Set up SSO with Azure AD"
This guide describes a feature of the dbt Cloud Enterprise plan. If you’re
interested in learning more about an Enterprise plan, contact us at
sales@getdbt.com.

If you are a [single-tenant (virtual private)](/docs/cloud/about-cloud/tenancy#single-tenant) customer, this SSO config docs is not for you. Instead, please [contact support](mailto:support@getdbt.com), if you wish to newly configure your SSO config or update your SSO config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "this SSO config docs is not" to "these SSO config docs aren't".

Also, I'd change newly to initially.

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jun 26, 2023
mirnawong1
mirnawong1 reviewed Jun 26, 2023
View reviewed changes
website/snippets/_sso-docs-mt-available.md Outdated

This guide describes a feature of the dbt Cloud Enterprise plan. If you’re interested in learning more about an Enterprise plan, contact us at <sales@getdbt.com>.

This SSO configuration document applies to multi-tenant Enterprise deployments only. [Single-tenant](/docs/cloud/about-cloud/tenancy#single-tenant) Virtual Private users can [email dbt Cloud Support](mailto:support@getdbt.com) to set up or update their SSO configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajaythomas @BrJan i created a snippet since this is repeated in multiple places. also suggested to reword it based on style guide. let me know what you think

mirnawong1
mirnawong1 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @ajaythomas @BrJan ! this is ready to merge and I've changed this to a snippet since it's repeated. I've also made some content changes - let me know what you think!

deploy preview

@mirnawong1
Copy link
Contributor

thanks ya'll, going to merge this now if there are no objections to the content and snippet used!

@mirnawong1 mirnawong1 merged commit 3ee5445 into current Jun 26, 2023
@mirnawong1 mirnawong1 deleted the ajay-updateSSODocsForVPC branch June 26, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrJan BrJan BrJan left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@saimaddali saimaddali Awaiting requested review from saimaddali

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaythomas @mirnawong1 @BrJan