Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update earliest version for access selection method and colocate with group #3613

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jun 24, 2023

Preview

What are you changing in this pull request and why?

  • Rearranged to colocate "group" and "access" methods
  • Update "access" from v1.6 to v1.5 since it was backported

🎩

v1.4

image

v1.5 and v1.6

image

Checklist

… group

- Rearranged to colocate group and access
- Update to 1.5 since this was backported
@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 36ab37c
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6499d7dd98e5d7000814ffbe
😎 Deploy Preview https://deploy-preview-3613--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jun 24, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review June 24, 2023 01:58
@dbeatty10 dbeatty10 requested a review from a team as a code owner June 24, 2023 01:58
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @dbeatty10 ! thank you for opening up and explaining this in detail ✨

@dbeatty10 dbeatty10 enabled auto-merge (squash) June 26, 2023 18:24
@dbeatty10 dbeatty10 merged commit 8472628 into current Jun 26, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/access-method-in-v1.5 branch June 26, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants