Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of server_side_parameters #3622

Merged
merged 11 commits into from
Aug 17, 2023
Merged

Add example of server_side_parameters #3622

merged 11 commits into from
Aug 17, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jun 27, 2023

What are you changing in this pull request and why?

I think it would be nice to show an example of the use of server_side_parameters.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@Fokko Fokko requested a review from a team as a code owner June 27, 2023 07:02
@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ac797f6
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64de67f33d45b600088b134f
😎 Deploy Preview https://deploy-preview-3622--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 27, 2023
@mirnawong1
Copy link
Contributor

hey @Fokko thanks for opening this up! we'll look at this for you on our end.

hey @dataders , looping you in. can you provide a technical review please?

@mirnawong1
Copy link
Contributor

thanks for opening this up @Fokko, great callout on this! I'll loop in @dataders as well. will go ahead and approve this ✨

dataders
dataders requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fokko lmk if i'm missing something here, but I don't see anywhere on this Spark Setup page that defines or explains what server_side_paramters is or does. Can you add a new subsection to "Optional configurations"?

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jul 7, 2023
@Fokko @dataders
Update website/docs/docs/core/connect-data-platform/spark-setup.md
ac797f6 
Co-authored-by: Anders <anders.swanson@dbtlabs.com>
dataders
dataders approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dataders dataders merged commit 31a5068 into dbt-labs:current Aug 17, 2023
7 checks passed
@Fokko Fokko deleted the patch-1 branch August 17, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@dataders dataders dataders approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fokko @mirnawong1 @dataders @matthewshaver @runleonarun