Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new EAT section in dbt cloud env page #3902

Merged
merged 19 commits into from
Aug 16, 2023
Merged

add new EAT section in dbt cloud env page #3902

merged 19 commits into from
Aug 16, 2023

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Aug 10, 2023

Per discussion with product and eng, adding a new section in the dbt cloud environment page to introduce a new EAT beta, which provides users more control over environments.

Refer to docs project for more info.

Closes #3938

@mirnawong1 mirnawong1 requested a review from a team as a code owner August 10, 2023 12:13
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit ba56a4e
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64dd46129d11a40008a54835
😎 Deploy Preview https://deploy-preview-3902--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs and removed size: small This change will take 1 to 2 days to address labels Aug 10, 2023
@mirnawong1 mirnawong1 changed the title add new eat section in dbt cloud env page add new EAT section in dbt cloud env page Aug 10, 2023
Copy link
Contributor

@ericbaumann ericbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this! Left a few comments, but overall loving this.

website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ericbaumann ericbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! left a comment about the blurb on special characters. I'm open to keeping a warning of some sort around that, but i think it'd be better being a little more open-ended and asking folks to reach out to us if they have issues with the text entry?

website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
website/snippets/_cloud-environments-info.md Outdated Show resolved Hide resolved
Comment on lines 71 to 78
snowflake:
target: dev
outputs:
dev:
type: snowflake
dbname: jaffle_shop
schema: dbt_alice
threads: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a valid example. It should be exactly the following:

dbname: jaffle_shop      
schema: dbt_alice      
threads: 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed that up, thanks @Fleid !

The following code is an example of the types of attributes you can add in the **Extended Attributes** text box:

```yaml
snowflake:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
snowflake:
dbname: jaffle_shop
schema: dbt_alice
threads: 4

@mirnawong1 mirnawong1 merged commit 9a79e54 into current Aug 16, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the mwong-add-ea branch August 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info about extended attributes
3 participants