New best practice guide for clone #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
mirnawong1
reviewed
Nov 29, 2023
|
|
||
| This can be suboptimal because: | ||
| - Typically incremental models are your largest datasets, so they take a long time to build in their entirety which can slow down development time and incur high warehouse costs. | ||
| - There are situations where a `full-refresh` of the incremental model passes successfully in your CI job but an _incremental_ build of that same table in prod would fail when the PR is merged into main (think schema drift where [on_schema_change](/docs/building-a-dbt-project/building-models/configuring-incremental-models#what-if-the-columns-of-my-incremental-model-change) config is set to `fail`) |
There was a problem hiding this comment.
Suggested change
| - There are situations where a `full-refresh` of the incremental model passes successfully in your CI job but an _incremental_ build of that same table in prod would fail when the PR is merged into main (think schema drift where [on_schema_change](/docs/building-a-dbt-project/building-models/configuring-incremental-models#what-if-the-columns-of-my-incremental-model-change) config is set to `fail`) | |
| - There are situations where a `full-refresh` of the incremental model passes successfully in your CI job but an _incremental_ build of that same table in prod would fail when the PR is merged into main (think schema drift where [on_schema_change](/docs/build/incremental-models#understanding-the-is_incremental-macro) config is set to `fail`) |
mirnawong1
reviewed
Nov 29, 2023
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
matthewshaver
commented
Nov 29, 2023
|
|
||
| **Relevant `dbt clone` Slack thread:** https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1692830261651829 | ||
|
|
||
| ### From the "Better CI for better data quality" coalesce talk |
There was a problem hiding this comment.
Do we feel like this chunk adds any value? If it's just repetitive, happy to cut it!
|
|
||
| ## Additional help | ||
|
|
||
| **Relevant `dbt clone` Slack thread:** https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1692830261651829 |
There was a problem hiding this comment.
This is an internal slack thread and would not be relevant to readers, this was just on the issue to add more color to what content we should include - we should cut this
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Closes issue #4359
Checklist
Adding new pages (delete if not applicable):
website/sidebars.js