Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update persist_docs.md to reflect dbx fix #5008

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

Update persist_docs.md to reflect fixed databricks persist column comments

dbt-labs/dbt-spark#372 (comment)

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Update persist_docs.md to reflect fixed databricks persist column comments

dbt-labs/dbt-spark#372 (comment)
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner February 28, 2024 16:46
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 11:04am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Feb 28, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this up @colin-rogers-dbt ! merging this for you ✨

@mirnawong1 mirnawong1 merged commit 8705d06 into current Mar 6, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the dbx-persist-column-comments-fixed branch March 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants