Restoring cross-database compatibility of example code #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
thanks for clarifying that @dbeatty10 ! apologies for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
What are you changing in this pull request and why?
The code change in #5326 was tested against a variety of dbt adapters. The update in #5306 modified that code example, and it appears to have database-specific cast syntax (
::) as well as a data type that means different things in different databases (i.e., theTIMESTAMPdata type has different semantics in BigQuery vs. Snowflake).So we should restore the code example in #5326. If there is a better example that has been tested across dbt adapters, then we can consider making another update in the future.
Checklist