Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple unique keys #6438

Merged
merged 19 commits into from
Nov 14, 2024
Merged

Adding multiple unique keys #6438

merged 19 commits into from
Nov 14, 2024

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Nov 8, 2024

Closes #6343

What are you changing in this pull request and why?

Adds multiple unique keys as outline in this plan.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@runleonarun runleonarun requested a review from a team as a code owner November 8, 2024 01:06
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 14, 2024 1:01am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Nov 8, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Nov 8, 2024
@runleonarun
Copy link
Collaborator Author

runleonarun commented Nov 8, 2024

Next steps

  • Test the code example
  • Get DX review

@runleonarun
Copy link
Collaborator Author

Hey @dbeatty10 This is ready for you to review! I tested the code snippet in the IDE and it worked (hopefully I did that right 😆 ):
Screenshot 2024-11-08 at 2 47 46 PM

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @runleonarun 👍

website/docs/docs/build/snapshots.md Show resolved Hide resolved
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt @runleonarun with a small sugg

runleonarun and others added 3 commits November 13, 2024 16:49
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@runleonarun runleonarun merged commit 988f1b7 into current Nov 14, 2024
13 checks passed
@runleonarun runleonarun deleted the mult-unique-keys branch November 14, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Support a list of multiple unique_keys in snapshots
3 participants