Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add behavior flag for microbatch #6455

Merged
merged 9 commits into from
Nov 12, 2024
Merged

add behavior flag for microbatch #6455

merged 9 commits into from
Nov 12, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Nov 11, 2024 •
edited by github-actions bot
Loading

@mirnawong1 mirnawong1 requested a review from a team as a code owner November 11, 2024 17:59
@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 12, 2024 7:18pm

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Nov 11, 2024
QMalcolm
QMalcolm reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small change requests. Thank you for putting this together ❤️

website/docs/docs/build/incremental-microbatch.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
nataliefiann
nataliefiann reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this. The link in section 171 didn't direct me to a page. I think I found the correct link. Let me know if I got it wrong though and I'll approve this for you.

Kind Regards
Natalie

nataliefiann
nataliefiann reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I've approved this for you.

Kind Regards
Natalie

QMalcolm
QMalcolm approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@mirnawong1 mirnawong1 merged commit 6a69ac0 into current Nov 12, 2024
13 checks passed
@mirnawong1 mirnawong1 deleted the add-microbatch-flag branch November 12, 2024 19:18
@runleonarun runleonarun restored the add-microbatch-flag branch November 12, 2024 23:46
@runleonarun runleonarun mentioned this pull request Nov 12, 2024
Merged
runleonarun added a commit that referenced this pull request Nov 12, 2024
@runleonarun
Revert "add behavior flag for microbatch" (#6466)
9ef32bd 
Reverts #6455
@runleonarun runleonarun mentioned this pull request Nov 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann left review comments

@QMalcolm QMalcolm QMalcolm approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Docs Changes Needed from dbt-core Issue #10798 Docs Changes Needed from dbt-adapters Issue #327
3 participants
@mirnawong1 @QMalcolm @nataliefiann