Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight job completion more on docs #6680

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Dec 17, 2024

this pr tries to showcase the trigger on job completion option more on the jobs page and other pages as well. it also turns the job completion section into mini steps and adds an image.

this was raised by @rcg798 in an internal slack thread


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 17, 2024 12:20
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 17, 2024 1:56pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed Docs team Authored by the Docs team @dbt Labs labels Dec 17, 2024
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Dec 17, 2024

| | **Deploy jobs** | **CI jobs** | **Merge jobs** |
| --- | --- | --- | --- |
| Purpose | Builds production data assets. | Builds and tests new code before merging changes into production. | Build merged changes into production or update state for deferral. |
| Trigger types | Triggered by a schedule or by API. | Triggered by a commit to a PR or by API. | Triggered by a successful merge into the environment's branch or by API.|
| Trigger types | Triggered by a schedule, API, or the successful completion of another job. | Triggered by a commit to a PR or by API. | Triggered by a successful merge into the environment's branch or by API.|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses @rcg798 's direct feedback

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Great PR! Thanks for creating this.
I've approved this for you.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit aa8ba41 into current Dec 17, 2024
8 checks passed
@mirnawong1 mirnawong1 deleted the update-deploy-language branch December 17, 2024 16:49
Copy link
Contributor

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants