Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix serverless sql #132

Merged
merged 18 commits into from
Apr 15, 2021
Merged

Hotfix serverless sql #132

merged 18 commits into from
Apr 15, 2021

Conversation

dataders
Copy link
Collaborator

Azure SQL Standard Tier is more expensive than hopefully needed. To make Azure SQL serverless work, I:

  • disabled the default columnstore option, and
  • made the connection-azuresql job come before the integration-azuresql job to ensure that the serverless db is unpaused/active before connecting

Comment on lines 8 to 10
sqlserver_integration_tests:
+as_columnstore: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 I thought this would be the right place for this but I'm still getting the error that this change was intended to fix:

'COLUMNSTORE' is not supported in this service tier of the database.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 14, 2021

@swanderz In order to override the pytest-dbt-adapter suite, you have to include the overrides directly in the .dbtspec file.

I'm hopeful that something like this would work. I'm not positive if dbt_project_yml can be a YAML dict or if it needs to be passed as a pythonic dict like so.

target:
  ...

projects:
  - overrides: base
    dbt_project_yml: &override-project
      name: dbt_test_project
      config-version: 2
      version: '1.0.0'
      models:
        +as_columnstore: false
  - overrides: ephemeral
    dbt_project_yml: *override-project
  - overrides: incremental
    dbt_project_yml: *override-project
  - overrides: snapshot_strategy_timestamp
    dbt_project_yml: *override-project
  - overrides: schema_tests
    dbt_project_yml: *override-project

sequences:
  ...

@jtcohen6
Copy link
Contributor

Just edited comment above based on this error. Checked and saw the project name is schema_tests (plural).

@dataders
Copy link
Collaborator Author

thanks @jtcohen6!
jeremy_bueller.jpg

@dataders dataders merged commit 83b8357 into master Apr 15, 2021
@dataders dataders deleted the HOTFIX--serverless-SQL branch April 15, 2021 16:02
alon-r pushed a commit to alon-r/dbt-sqlserver that referenced this pull request May 26, 2021
* low-end serverless tier has no columnstore
* use cxn test to wake up serverless db
* no columnstore
* add new tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants