drop macro sqlserver__drop_relation() #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my first thought was to make `sqlserver__drop_relation` just a wrapper for `sqlserver__drop_relation_script`, but then I looked and found it isn't ever used...
|
Thanks! sqlserver__drop_relation is the "real" drop_relation script that dbt uses when they want to drop a relation. I don't exactly remember why i created the other one. But it was for solving an issue with temp-relations laying around and stop new runs from succeed. I think there was difficult to use the "real" one in the other script. I should look into this again to make it look clearer at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my first thought was to make
sqlserver__drop_relationjust a wrapper forsqlserver__drop_relation_script, but then I looked and found it isn't ever used...