Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application name ODBC parameter #98

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Feb 2, 2021

My bad for directing us to the wrong docs in #63. Instead of APP we want Application Name. From Synapse PM:

On the application name parameter, for ODBC, please use “Application Name=dbt-{credentials.type}” (per your example). The key here is the parameter being “Application Name” with a space between Application and Name. If you happen to use JDBC, then you can use applicationName (no space).

While we're here, I figure it can't hurt to send the dbt-sqlserver version as well.

@dataders
Copy link
Collaborator

dataders commented Feb 2, 2021

thanks @jtcohen6! two qqs:

  • If I want to include this change as part of dbt-synapse v0.19.0, does that mean we should cut a new release of dbt-sqlserver?
  • if so, what version should that be? I'm hesitant to go with v0.19.1 bc it'll likely be a dbt-core version we might need to support. Maybe v0.19.0.1? But, IIRC, any addition after the patch number makes PyPI think it is a pre-release.

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Feb 3, 2021

Yes to a new release, and I think v0.19.0.1 is the right way to go! We released dbt-spark==0.18.1.1 when we needed a small fix, but still wanted to indicate version parity with dbt-core==0.18.1. I believe that PyPi/pip treat a version as pre-release IFF its suffix is dev, a, b, or rc (docs).

@dataders dataders merged commit 0d529de into dbt-msft:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants