Skip to content

Commit

Permalink
Fixing up row chart x axis label positioning
Browse files Browse the repository at this point in the history
  • Loading branch information
ruhley committed Nov 2, 2015
1 parent 9a6acad commit 27c03a4
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* Paired Row Charts (137213b566ae39e5f646016c9f13e30b0f6385a1 / 1267f7a82d4b8280d102460e1e85126aaffd0a60 / 5494b449f95a183bbc8416aa01b7bbc37efcf460 / 8c5ed0de8ac914c934da497fbfc54d7c85caa22f)
* New ```clickOn``` option to disable all clicking events (c65346338df0f88a24847fd518cd950f657d0ae6)
* ```xAxisTickLabelRotate``` and ```yAxisTickLabelRotate``` (d2bcf2338e21e5f7f3c9c4ff63e93e3cb2f7383d / f9e08c55fbe99649ae0b8052672f988aae81ee03)
* Row chart ```xAxisLabel``` (c6e473bf359f069f5d4e6883d16f25827084a7a0 / a8d72ae8b8a2d0d4a4dce11b377f044365cd58fc)
* Wrap x axis labels if string is too long (f939481ff921e6020d97e508728546dca0260c45)
* Row chart ```xAxisLabel``` (c6e473bf359f069f5d4e6883d16f25827084a7a0 / a8d72ae8b8a2d0d4a4dce11b377f044365cd58fc / 289ae4600a53aa7a3396e9d95257264535fc5cfc)
* Wrap x axis labels if string is too long (f939481ff921e6020d97e508728546dca0260c45 / 9cd85df7e43ca57c4504a09b0091de53321fb2ff / 7196dfa8c35c4f0da6be26cc102a031c06cd255b)

## 2.1.0
* Heatmap allows customizing the ordering separately from the values, by Matt Traynham ([#869](https://github.com/dc-js/dc.js/pull/869) - thanks also to Quinn Lee for [#837](https://github.com/dc-js/dc.js/pull/837))
Expand Down
4 changes: 2 additions & 2 deletions dc.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dc.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dc.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dc.min.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/row-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ dc.rowChart = function (parent, chartGroup) {
axisXLab = _g.append('text')
.attr('class', X_AXIS_LABEL_CLASS)
.attr('transform',
'translate(' + (_chart.margins().left + _chart.xAxisLength() / 2) +
'translate(' + (_chart.xAxisLength() / 2) +
',' + (_chart.height() - _xAxisLabelPadding) + ')'
)
.attr('text-anchor', 'middle');
Expand All @@ -113,7 +113,7 @@ dc.rowChart = function (parent, chartGroup) {
}

dc.transition(axisXLab, _chart.transitionDuration())
.attr('transform', 'translate(' + (_chart.margins().left + _chart.xAxisLength() / 2) + ',' +
.attr('transform', 'translate(' + (_chart.xAxisLength() / 2) + ',' +
(_chart.height() - _xAxisLabelPadding) + ')');
}

Expand Down
4 changes: 2 additions & 2 deletions web/js/dc.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/js/dc.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions web/js/dc.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion web/js/dc.min.js.map

Large diffs are not rendered by default.

0 comments on commit 27c03a4

Please sign in to comment.