Drop includeStorageKey during filter serialization, no longer needed

dc-js · Apr 1, 2024 · c0e4785 · c0e4785
1 parent 97d3156
commit c0e4785
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/src/core/filter-storage.ts b/src/core/filter-storage.ts
@@ -1,4 +1,4 @@
-import { IFilterListenerParams, IFilterStorage, ISerializeOpts } from './i-filter-storage.js';
+import { IFilterListenerParams, IFilterStorage } from './i-filter-storage.js';
 import { IFilter } from './filters/i-filter.js';
 import { filterFactory } from './filters/filter-factory.js';
 import { ISerializedFilters } from './i-serialized-filters.js';
@@ -100,7 +100,7 @@ export class FilterStorage implements IFilterStorage {
         this.setFiltersAndNotify(storageKey, filters);
     }
 
-    public serialize({ includeStorageKey }: ISerializeOpts = {}): ISerializedFilters[] {
+    public serialize(): ISerializedFilters[] {
         // Include items that have active filters
         // In case of Composite charts, include only the parent chart
         return Array.from(this._listenerChains.values())
@@ -111,15 +111,11 @@ export class FilterStorage implements IFilterStorage {
                 if (listener) {
                     const filters = this._filters.get(listener.storageKey);
                     if (filters && filters.length > 0) {
-                        const entry = this._serializeFilters(
-                            listener.dimId,
-                            listener.dimLabel,
-                            filters
+                        return this._serializeFilters(
+                          listener.dimId,
+                          listener.dimLabel,
+                          filters
                         );
-                        if (includeStorageKey) {
-                            entry.storageKey = listener.storageKey;
-                        }
-                        return entry;
                     }
                 }
                 return undefined;

diff --git a/src/core/i-filter-storage.ts b/src/core/i-filter-storage.ts
@@ -9,17 +9,13 @@ export interface IFilterListenerParams {
     applyFilters: (filters) => void;
 }
 
-export interface ISerializeOpts {
-    includeStorageKey?: boolean;
-}
-
 export interface IFilterStorage {
     setFiltersFor(storageKey: any, filters);
     getFiltersFor(storageKey: any);
     registerFilterListener(opts: IFilterListenerParams): any;
     deRegisterFilterListener(storageKey: any, listner: any): void;
     notifyListeners(storageKey: any, filters): void;
     deRegisterAll(): void;
-    serialize(opts?: ISerializeOpts): ISerializedFilters[];
+    serialize(): ISerializedFilters[];
     restore(state: object): void;
 }