Added deprecation logging

dc-js · Jan 13, 2015 · cfbc31e · cfbc31e
1 parent 9735741
commit cfbc31e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/base-mixin.js b/src/base-mixin.js
@@ -996,9 +996,9 @@ dc.baseMixin = function (_chart) {
     ```
 
     **/
-    _chart.renderlet = function (_) {
+    _chart.renderlet = dc.logger.deprecate(function (_) {
         _chart.on(RENDERLET_KEY + '.' + dc.utils.uniqueId(), _);
-    };
+    }, 'chart.renderlet has been deprecated.  Please use chart.on("renderlet.<renderletKey>", renderletFunction)');
 
     /**
     #### .chartGroup([group])

diff --git a/src/logger.js b/src/logger.js
@@ -25,3 +25,16 @@ dc.logger.debug = function (msg) {
 
     return dc.logger;
 };
+
+dc.logger.deprecate = function (fn, msg) {
+    // Allow logging of deprecation
+    var warned = false;
+    function deprecated() {
+        if (!warned) {
+            dc.logger.warn(msg);
+            warned = true;
+        }
+        return fn.apply(this, arguments);
+    }
+    return deprecated;
+};