bar chart draw bounds enclosing old and new domain

to avoid the gap technically we could remove what's outside the drawing area afterward
dc-js · Sep 12, 2016 · dd94478 · dd94478
1 parent df6aefa
commit dd94478
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/bar-chart.js b/src/bar-chart.js
@@ -50,8 +50,10 @@ dc.barChart = function (parent, chartGroup) {
     }, false);
 
     _chart.plotData = function (params) {
+        var bounds = _chart.isOrdinal() ? null : params.fullBounds();
+        var stackData = _chart.computeStacks(bounds);
         var layers = _chart.chartBodyG().selectAll('g.stack')
-                .data(_chart.data());
+                .data(stackData);
         params.preBarWidth = calculateBarWidth(params.preXScale);
         params.postBarWidth = calculateBarWidth(params.postXScale);
 

diff --git a/src/coordinate-grid-mixin.js b/src/coordinate-grid-mixin.js
@@ -1165,7 +1165,13 @@ dc.coordinateGridMixin = function (_chart) {
             preXScale: _lastXScale || _x,
             preYScale: _lastYScale || _y,
             postXScale: _x,
-            postYScale: _y
+            postYScale: _y,
+            fullBounds: function () {
+                return [
+                    Math.min(this.preXScale.domain()[0], this.postXScale.domain()[0]),
+                    Math.max(this.preXScale.domain()[1], this.postXScale.domain()[1])
+                ];
+            }
         });
 
         if (_chart.elasticX() || _resizing || render) {