-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html docs: relative links are gone #1098
Comments
As far as I can tell this is the only real blocker for "going live" with the HTML docs. (They're already online but not linked to anywhere.) Internal links are pretty important; it looks like we have at least 64 of them:
Examples of missing links: "brush" in http://dc-js.github.io/dc.js/docs/html/dc.lineChart.html#xyTipsOn__anchor |
Figured it out, our links should take the format:
Took me a while to find the class format. Will add a PR shortly. |
Sweet! |
fixed by #1109 |
JSDoc / docstrap is stripping out any links which point within the documentation. These were previously handled by relative hash-links (e.g.
{@link #dc.coordinateGridMixin+brushOn}
) which obviously won't work.Probably JSDoc has a way to specify links semantically within a body of documentation.
Follow up to #1086
The text was updated successfully, but these errors were encountered: