Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Bar Charts #1296

Closed
wei-jwarren opened this issue Apr 13, 2017 · 3 comments
Closed

Error with Bar Charts #1296

wei-jwarren opened this issue Apr 13, 2017 · 3 comments

Comments

@wei-jwarren
Copy link

Im running the dc cloudflare cdn version 2.1.4 and when I try to render bar charts I get an error that b.size() is not a function.
Its happening on var last = layers.size() - 1; I saw that someone else had this issue but they were using meteor. Can anyone help me with this?

@gordonwoodhull
Copy link
Contributor

So, you found issue #1118 already and it looks like that issue arose because meteor packaged an obsolete version of d3.js.

Could you be facing the same issue? dc.js is compatible with d3.js 3.x but I wouldn't try it with anything less than 3.5.

Ah, I see you closed this while I was typing. Was this the correct diagnosis?

@wei-jwarren
Copy link
Author

Exactly. It was the exact same issue. I miss read the original solution. I thought he said he was using DCjs 3.x and I was confused but it was D3js 3.x. Once I switched it to 3.5 it worked.

@gordonwoodhull
Copy link
Contributor

Great, thanks for confirming!

frankisans pushed a commit to saicoi/dc.js that referenced this issue Jun 15, 2017
fixes dc-js#1296

s/value.value/value.total/ because wot
use describe blocks with beforeEach for each configuration
use -kv.value ordering for a test or two, it's the normal thing to do
takeFront is now the default so that broke a lot of the changes from dc-js#1184

group order no longer matters but retain a test showing how -kv.value is
equivalent

at least two tests made no sense before or after dc-js#1184, hopefully they
do now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants