Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix entering transition positions #1400

Closed
5 tasks done
gordonwoodhull opened this issue Apr 8, 2018 · 2 comments
Closed
5 tasks done

fix entering transition positions #1400

gordonwoodhull opened this issue Apr 8, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Apr 8, 2018

It seems that the default value must have changed for attributes which were not specified in the enter step but then transition in the update step.

Whereas before the unspecified initial position seemed to just take the final position, now it seems to start at zero.

I did not find any code changes in #1363 to explain this, so I reluctantly blame d3v4. Or I don't know, maybe it's a better, more consistent behavior, but it breaks all the things listed in #1363:

bar charts

  • introductory transition on bars is from lower left instead of just from bottom
  • bar labels animate from upper left instead of just being there at start

line charts

  • dots animate from upper left instead of just being there

heat map

  • squares animate from upper right instead of just fading in
  • y axis ticks animate from top instead of just being there

and there are likely to be more. Seems like it would affect colors as well.

It's probably good to fully specify initial values on enter, even if it's a little tedious sometimes

@gordonwoodhull gordonwoodhull added this to the 3.0 milestone Apr 8, 2018
@gordonwoodhull gordonwoodhull self-assigned this Apr 8, 2018
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull added a commit that referenced this issue Apr 12, 2018
because d3v4 doesn't default to the transition position anymore
for #1400
gordonwoodhull added a commit that referenced this issue Apr 12, 2018
because d3v4 doesn't default to the transition position anymore
for #1400
gordonwoodhull added a commit that referenced this issue Apr 12, 2018
because d3v4 doesn't default to the transition position anymore
for #1400
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Apr 12, 2018

I think I got all of them. 3.0 alpha 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant