Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiting bars turn grey first #1401

Closed
gordonwoodhull opened this issue Apr 8, 2018 · 7 comments
Closed

exiting bars turn grey first #1401

gordonwoodhull opened this issue Apr 8, 2018 · 7 comments
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

From #1363

In the multi focus example, bars turn grey before being filtered/focused (?) out instead of just disappearing. Not sure which behavior is better here, but we should figure out what is going on here and decide one way or the other.

Also, the bars stay deselected when the range chart is reset to no filter:

image

Looks like the reset bug can be fixed by simplifying the example. Applying fadeDeselected to the focus charts is arguably correct but distracting & annoying.

gordonwoodhull added a commit that referenced this issue Apr 8, 2018
@gordonwoodhull gordonwoodhull added this to the 3.0 milestone Apr 8, 2018
@kum-deepak
Copy link
Collaborator

Are you going to work on this, or, should I pick it up?

@gordonwoodhull
Copy link
Contributor Author

Feel free to take it. I guess we are applying fadeDeselected earlier than we used to.

@kum-deepak
Copy link
Collaborator

Tried to find a solution. However I am unable to find any simple code fix. Please see if you are able to find a solution.

@gordonwoodhull
Copy link
Contributor Author

I think we'll have to live with the change - it should only affect range/focus bar charts. It's a little annoying but it's arguably correct.

@kum-deepak
Copy link
Collaborator

Please check #1422

@gordonwoodhull
Copy link
Contributor Author

Your fix makes sense. Will check this morning.

@gordonwoodhull
Copy link
Contributor Author

Fixed in 3.0 beta 1

gordonwoodhull added a commit that referenced this issue Apr 20, 2018
where there is no concept of "no brushing"
ref #1422 #1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants