lineChart.renderDataPoints(false) doesnt disable point rendering

[stevemandl]

The comments state:
If options is falsy, it disables data point rendering.
This is not happening; drawDots() will always render the data points as long as brushing is not enabled. Here is my proposed solution - A minor change to the beginning of drawDots seems to fix the problem:

function drawDots(chartBody, layers) {
    if (!_chart.brushOn() && _dataPointRadius) { 

instead of

function drawDots(chartBody, layers) {
    if (!_chart.brushOn()) { 

...

[sclevine]

Setting .renderDataPoints(false) will disable rendering each data point on the chart by setting:

_dataPointFillOpacity = DEFAULT_DOT_OPACITY;
_dataPointStrokeOpacity = DEFAULT_DOT_OPACITY;

where

var DEFAULT_DOT_OPACITY = 1e-6;

This results in invisible dots that are made visible on hover events. Changing the drawDots conditional to !_chart.brushOn() && _dataPointRadius breaks the dot rendering on those hover events. #renderDataPoints() is only intended to control whether or not the data points appear at all times.

I do agree that the current implementation is confusing, and we would certainly consider accepting a pull request to clear this up :)

[gordonwoodhull]

If the request is to not show the dots even on hover, #735 should cover that. I agree the name is kind of confusing.