Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new boolean property on linechart to toggle mouseover dots #735

Merged

Conversation

davisford
Copy link
Contributor

So, on line charts, this feature:

screen shot 2014-10-18 at 12 21 31 am

i.e. the x/y tracking to the axes, and the dot that tracks the line on mouseover is something that is currently not optional. It is always generated. I had a need to build something else for my line charts...namely a tracker that shows up not just if you mouseover on the line but on the whole chart, and also a linear regression slope, and I wanted a larger dot to make it more visible.

screen shot 2014-10-18 at 12 26 41 am

Seeing as how my linechart features collided with the built-in features, I wanted to make the built-in features optional, so I added a new property on linechart:

linechart.xyTipsOn(true); // the default
linechart.xyTipsOn(false); // disable the tracking dot and xy refs

By default, the behavior is still on, so it should affect nothing. This just gives me the ability to disable it to inject my own behavior that doesn't collide with it.

Added documentation for the new public API, as well as a few unit tests.

@davisford davisford changed the title add new boolean property on line chart to enable/disable mouseover for x... new boolean property on linechart to toggle mouseover dots Oct 18, 2014
@gordonwoodhull gordonwoodhull modified the milestone: v2.0 Jan 17, 2015
gordonwoodhull added a commit that referenced this pull request Apr 3, 2015
@gordonwoodhull gordonwoodhull merged commit f3cf915 into dc-js:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants