-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brush not filtering when using composite chart #878
Comments
This is a duplicate of, well, a lot of things. This branch is a start on a solution: Please try it out and see if it helps. Will merge to develop soon. |
Any news on this one? |
As of 2.0.0-beta32, CompositeChart's _chart._brushing() still does not trigger any redraw events. The google group link posted by Fil did not work for me. A solution that worked for me is to simply comment out CompositeChart's _chart._brushing() function. This makes CompositeCharts use CoordinateGridMixin's _chart._brushing() for brushing, and works just fine. |
Thanks @joysword, that sounds like a good workaround, as long as the dimension is the same for the composite and its children. I think we could make it possible to restore the overridden method without having to change the source. |
@Fil updated for 404'd external resources http://jsfiddle.net/cBgkT/42/ The redefined _chart._brushing function works if the composite graph has the defined dimension but fails if the sub-charts have defined dimensions. |
When I override the |
…le to produce a selection over identification_dates due to this bug: dc-js/dc.js#878
Fixed by #1408 in 3.0.2 |
Is this supposed to work?
If I create a line chart with a data table, selecting an area of the chart with the brush filters the data in the table. If I take that same line chart and wrap it in a composite chart (even if it is the only chart in the composite), the data table no longer gets filtered.
My code is the same in each case except for this:
versus:
The text was updated successfully, but these errors were encountered: