Heatmaps seem to be empty after crossfilter reloads data #1032
Conversation
`selectAll` does not inherit data from its parent. This means that if the underlying crossfilter gets new data the selection of `g.box-group` will see the new data, the children `title` and `rect` will not. The optical result of that is a seemingly emtpy heatmap although the data has changed.
|
Thanks @smee! Good catch. |
|
Thanks @mtraynham - this is confusing because in most of the code you refer to, the data is used right on the next line. And it doesn't seem to be nested data. I think we would know if all these locations were failing. So are there some cases where selectAll will in fact replicate the data to the child? |
|
Well I deemed these cases as bad, because it was using a I believe some of these may be masked by the fact that we transition the same nodes twice: |
|
Nice! Hmm. Just when I thought I understood selections. I agree they should be |
|
See #1237 (comment) for the reason this doesn't break the whole world. (Hint: most people use crossfilter, but dc.js doesn't require you to.) |
|
Yesterday Mike posted a detailed rationale for why |
|
adding test and merging for 2.0. thanks @smee! |
|
still need to check against the very helpful @mtraynham list above |
selectAlldoes not inherit data from its parent. This means that if the underlying crossfilter gets new data the selection ofg.box-groupwill see the new data, the childrentitleandrectwill not. The optical result of that is a seemingly empty heatmap although the data has changed.