Add browser: dc.js to package.json for Browserify #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make Browserify skip bundling the scripts intended to run on CommonJS platforms and instead make it bundle dc.js directly. This fixes problems where Browserify is unable to find jsdom because it is not listed in the dependencies (and is not required on browser anyway). Resolves dc-js#1005.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make Browserify skip bundling the scripts intended to run on
CommonJS platforms and instead make it bundle dc.js directly. This fixes
problems where Browserify is unable to find jsdom because it is not listed
in the dependencies (and is not required on browser anyway). Resolves #1005.