Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #1096, #1097, #1099, #1100: Fix some outstanding issues with HTML JSDoc #1101

Closed
wants to merge 3 commits into from

Conversation

mtraynham
Copy link
Contributor

Should resolve #1096, #1097, #1099, #1100.

For #1099, I tried splitting up the files and it seemingly fixed the paths, which also resolves #1100...

Minor caveat on #1097 (the classes). Both jsdoc2md and grunt-jsdoc (with docstrap) add the "new" keyword to these classes. Most of the documentation doesn't use it, but dc.js will work with/without the keyword...

@mtraynham
Copy link
Contributor Author

Aww fudge, targeted for develop. Might want to pull back into master.

@gordonwoodhull
Copy link
Contributor

NP, I am pretty used to cherry-picking commits rather than doing straight merges.

Working on the docs raises a weird workflow issue: develop has more (pseudo)classes than master does. Currently just the one, selectMenu, needed its own separate update on develop. I'm not sure what the best approach is here. I guess it only affects these PRs that change just about every file, so it's not worth coming up with a procedure. But it's interesting that these kinds of changes can't be made in a single PR.

@gordonwoodhull
Copy link
Contributor

I merged this to master and develop. Since it doesn't affect the released code/markdown, there's no need for a tag/release, but the changes will be part of 2.0 beta 27 when that comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html docs: don't concatenate source html docs: no pseudoclass parameters
2 participants