Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use valid sans-serif value #1260

Closed
wants to merge 1 commit into from
Closed

Conversation

kdoh
Copy link
Contributor

@kdoh kdoh commented Jan 13, 2017

Because $font_sans_serif was defined as a string in dc.scss the browser would look for a font called "sans-serif" instead of using a system sans-serif typeface. We recently discovered this after bumping our dc.js version and noticed our axis labels had changed in metabase/metabase#4115

@kdoh kdoh changed the base branch from develop to master January 13, 2017 18:20
@gordonwoodhull
Copy link
Contributor

Thanks @kdoh, good catch, that Times definitely doesn't look so sharp at that tiny size!

I guess we missed this when refactoring to Sass in #1049.

Released in 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants