Subscribe to rangeChart's filtered event with a namespace #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlbyk
force-pushed
the
rangeChart-filtered
branch
from
73da19d to
0653247
Compare
dahlbyk
force-pushed
the
rangeChart-filtered
branch
from
0392f8a to
7a86da1
Compare
|
Rebased onto I'll leave the 2.x version at da3c437...NewBoCo:rangeChart-filtered-2.x in case anyone needs it. |
dahlbyk
force-pushed
the
rangeChart-filtered
branch
from
7a86da1 to
d04d39a
Compare
|
Thanks @dahlbyk! Merged for 3.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842. It's trivial to change, but for now I've chosen a more specific namespace than
.dcjs, considering the possibility of internal conflicts. I couldn't find any other examples of internal event subscriptions.