Prepare x axis - added warning #1414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also want to update all test cases to use |
|
That sounds good! I guess you'd be able to test both that the warning happens and that the scale gets replaced. |
…e chart examples. Removed web/ep/list.js - seems to be stale file.
…or deprecation of dc.scaleOrdinal()
|
Finished work for this round, ready for your review. 👍 |
|
Great work, thanks @kum-deepak! Merged for 3.0 alpha 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn before converting d3.scaleOrdinal() to d3.scaleBand(). Updated all examples accordingly.
There is one unrelated change in this PR - I have removed /web/ep/list.js. It seemed stale and was probably not getting used.