_prepareYAxis changes and Axis related documentation updates #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API documentation changes. Fixes part of #1398.
| 'You might get unexpected yAxis behavior. ' + | ||
| 'Make calls to useRightYAxis sooner in your chart creation process.'); | ||
| } | ||
|
|
|
Looks good - I have a feeling this still may bite people, but I think we're doing the best we can with defaults and warnings. We'll soon see! Thanks @kum-deepak! Merged for 3.0 alpha 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #1398.
_yAxisis initially null and gets initialized when first needed based on whether it will left or right axis. Also added a warning in case axis orientation changes after y axis was initialized.Several corrections in documentation of axes.