Allow stroke to be used for line-chart data points #1449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line-chart dataPoints and set default value for dataPoints.strokeOpacity to 0.0, update line-chart-spec test for default options
|
Thanks @rmanzano-TE, merged for 3.0.6. If you're online today, could you tell me your first name for the AUTHORS file? |
|
Per special request, I'm also releasing 2.2.1 with this change. Sorry it took a while! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove stroke: none css rule for circle.dot, add stroke attribute to line-chart dataPoints and set default value for dataPoints.strokeOpacity to 0.0, update line-chart-spec test for default options
see #1447