Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlightSelected funcs implemented to dc.legend #1625

Closed
wants to merge 2 commits into from
Closed

highlightSelected funcs implemented to dc.legend #1625

wants to merge 2 commits into from

Conversation

Tahirhan
Copy link
Contributor

background-color didn't work in SVG, so i used fill for highlighting selected legend item.

@gordonwoodhull
Copy link
Contributor

Thanks @Tahirhan! dc.js and dc.css are generated files - could you make the changes to src/legend.js and style/dc.scss instead?

This fixes #600.

@Tahirhan
Copy link
Contributor Author

Oh, ok i made changes.

@gordonwoodhull
Copy link
Contributor

Thanks @Tahirhan, merged for release 3.1.9

gordonwoodhull added a commit that referenced this pull request Dec 16, 2019
@gordonwoodhull
enabled highlightSelected in an example
eed3187 
for #1625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tahirhan @gordonwoodhull