Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cumulative line chart. #1780

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

kum-deepak
Copy link
Collaborator

It seems the cumulative line in the Pareto chart example is incorrect. Removing the sort in the fake group seems to fix it. Please review.

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Nov 1, 2020

The bars should be sorted from greatest to least, but they aren't taking the ordering from the group.

According to the screenshot, the example worked \ when I answered the question on SO, but already the fiddle does not work, so I don't know what happened.

This fixes it:

        .ordering(kv => -kv.value.value)

@kum-deepak
Copy link
Collaborator Author

Thanks, @gordonwoodhull! I have updated the code.

@kum-deepak
Copy link
Collaborator Author

The scatter-series example was showing the issue reported in #1772. Switching off mouseZoomable.

@gordonwoodhull gordonwoodhull merged commit 0127aff into dc-js:develop Nov 2, 2020
@gordonwoodhull
Copy link
Contributor

Thanks @kum-deepak!

@kum-deepak kum-deepak deleted the pareto branch November 3, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants