fix(coordinateGridMixin): renderVerticalGridLines should consider useTopXAxis #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gordonwoodhull would you mind to review this whenever you have a spare few mins? |
|
Sorry for the slow response. This makes sense to me and I will merge it next release. If you would be so kind as to add a test case or two, we can ensure that the new feature keeps working into the future. If you add a test case that fails without this fix and succeeds with it, I think that will be sufficient to test Thanks! |
|
@gordonwoodhull no probs at all. Will try to write some tests in due course. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1818