Provide programmatic column header for table, stock example updated #560

mr23 · 2014-04-01T04:53:58Z

Update: ready to go, April 5.

Still allows original example to function as-is. Allows non-hard-coded table column headers.

Supplied 3 examples of setting the columns; the original method, which requires the fixed html code for thead/cols; another which uses mostly the data element names which become capitalized as col headings, and another where most of the columns have the column label specified along with an accessor function. There is some code to strip a numberFormat/etc from a function converted to string, an attempt to auto-generate a column header from a function, in data-table.js, columnString().

mr23 · 2014-04-01T04:55:35Z

I've since learned to pull a topic branch, and prior to the pull reversed the commit of the auto-built dc.js's.

mr23 · 2014-04-01T05:39:07Z

I'm not sure what is wrong, it passes the grunt test here and shows as synced.

mr23 · 2014-04-02T01:39:58Z

Installed saucelab. Retry

mr23 · 2014-04-02T03:22:48Z

Ah, went down a dark alley.
"Please note that encrypted environment variables are not available for pull requests from forks."

Perhaps someone will smile gently and provide some wisdom for a newbie.

mr23 · 2014-04-02T03:52:46Z

Ah. I see this is a common Sauce problem at the moment.
I humbly await.

gordonwoodhull · 2014-04-02T03:54:40Z

Hi @mr23, sorry for this bad first PR experience! and sorry I didn't intervene sooner.

There is really nothing to worry about, I think the Sauce system changed last week and everything has been failing since. Your patch should be good if it passed the tests before that part.

I'm tied up with other deadlines this week but will review your contribution soon.

sclevine · 2014-04-02T04:52:18Z

@mr23, sorry for the trouble!
Should be fixed in 16e6863. Would you mind rebasing against master?

mr23 · 2014-04-02T14:17:22Z

Ready

ChrisMeierRT · 2014-04-04T20:14:37Z

How do we go about updating the API (https://github.com/dc-js/dc.js/blob/master/web/docs/api-latest.md)? The section on columns (.columns([columnFunctionArray])) still applies as-is, but I added additional functionality.

gordonwoodhull · 2014-04-04T20:23:51Z

Just add to the comment around
https://github.com/mr23/dc.js/blob/master/src/data-table.js#L169

This is a valuable contribution and I have seen other workarounds by other users.

I have two comments so far:

please refactor to make your column namer a function parameter. So instead of just generating column names with capitalizeString and columnString, put those into a function much the same way accessors work. What you have would be a good default but I'm sure others will want this work a different way.
please don't use tabs - follow the formatting of the code around it. Often this means replacing tabs with 8 spaces but look and see what it means for your code.

Restored index.html, no need for a change. Added 4th example of columns.

so both header and value can be overridden

Changed to use just an in-line Object, and allow any Object specification desired, with note to override the internal functions to match. I think this is the cleanest and most flexible version.

mr23 · 2014-04-05T21:10:32Z

Gordon, SC,
I believe this is ready to go, See comments immediately above for the groups of changes.
Let me know if you need anything further.
-Chris

gordonwoodhull · 2014-04-18T17:25:06Z

src/data-table.js

+	// A 2nd option is a string representing a field in the data. 
+	// A third option is to supply an Object such as an array of 'information', and
+	// supply your own _doColumnHeaderFormat and _doColumnValueFormat functions to
+	// create what you need.


This comment confuses me. It doesn't look like one would provide _doColumnHeaderFormat and _doColumnValueFormat, but instead would supply the header string and a format function. Is this comment obsolete?

gordonwoodhull · 2014-04-18T17:27:38Z

This looks really helpful. Using the example for testing is great, but could you add jasmine tests for the following cases?

labels only
functions only
objects only
no header (is this still supported?)

For the Object formatting, I would prefer an object rather than an array. So, instead of

                ["Open",
              function (d) {
              return numberFormat(d.open);
              }],

I would prefer something like:

                {label: "Open",
              format: function (d) {
              return numberFormat(d.open);
              }},

It's a little more verbose but clearer.

Thanks!

mr23 · 2014-04-29T17:16:27Z

Okay, I'll look into it next opportunity.

mr23 · 2014-07-27T03:39:49Z

Going to try and pick this back up. Could it still make a cutoff for 2.0 ?

gordonwoodhull · 2014-07-27T06:07:59Z

Yeah, I hope to release mid-week.

gordonwoodhull · 2014-07-27T06:08:43Z

Also, there shouldn't be quite such a long wait between releases after that!

…r columns and add jasmine tests

gordonwoodhull · 2014-09-29T02:01:55Z

This was subsumed/replaced by #668, which adds tests.

Chris Meier added 3 commits March 30, 2014 22:45

table header moved to dc.js

cf310a0

Still allows original example to function as-is. Allows non-hard-coded table column headers.

fixing unintended checkins

c466f6c

updated stock example via grunt

c13392f

Chris Meier added 2 commits April 1, 2014 20:12

attempt again, renderedstockfixture

a245ae3

attempt3 after installing saucelab; touched data-table.js

9efd1d7

retry 4. connected sauce

364c712

Chris Meier added 4 commits April 5, 2014 13:33

review changes

77cad1e

Restored index.html, no need for a change. Added 4th example of columns.

updated restored stock example

67b8d7f

added ValueFormat function

7d6ac8e

so both header and value can be overridden

Removed columnHelper fn

3501065

Changed to use just an in-line Object, and allow any Object specification desired, with note to override the internal functions to match. I think this is the cleanest and most flexible version.

gordonwoodhull reviewed Apr 18, 2014
View reviewed changes

gordonwoodhull added this to the v2.0 milestone Jun 5, 2014

axiomabsolute pushed a commit to axiomabsolute/dc.js that referenced this pull request Aug 8, 2014

Incorporated feedback from PR dc-js#560 to alter Object formatting fo…

a208a90

…r columns and add jasmine tests

mr23 mentioned this pull request Aug 9, 2014

Adding tests and revisions to PR #560 : Provide programmatic column header for table, stock example updated #668

Merged

gordonwoodhull modified the milestone: v2.0 Sep 29, 2014

gordonwoodhull closed this Sep 29, 2014

gordonwoodhull mentioned this pull request Dec 14, 2015

dataTable not working with fancy columns #1030

Closed

gordonwoodhull mentioned this pull request Jul 21, 2020

DataTable - cleanup - fragile code #1721

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide programmatic column header for table, stock example updated #560

Provide programmatic column header for table, stock example updated #560

mr23 commented Apr 1, 2014

mr23 commented Apr 1, 2014

mr23 commented Apr 1, 2014

mr23 commented Apr 2, 2014

mr23 commented Apr 2, 2014

mr23 commented Apr 2, 2014

gordonwoodhull commented Apr 2, 2014

sclevine commented Apr 2, 2014

mr23 commented Apr 2, 2014

ChrisMeierRT commented Apr 4, 2014

gordonwoodhull commented Apr 4, 2014

mr23 commented Apr 5, 2014

gordonwoodhull Apr 18, 2014

gordonwoodhull commented Apr 18, 2014

mr23 commented Apr 29, 2014

mr23 commented Jul 27, 2014

gordonwoodhull commented Jul 27, 2014

gordonwoodhull commented Jul 27, 2014

gordonwoodhull commented Sep 29, 2014

Provide programmatic column header for table, stock example updated #560

Provide programmatic column header for table, stock example updated #560

Conversation

mr23 commented Apr 1, 2014

mr23 commented Apr 1, 2014

mr23 commented Apr 1, 2014

mr23 commented Apr 2, 2014

mr23 commented Apr 2, 2014

mr23 commented Apr 2, 2014

gordonwoodhull commented Apr 2, 2014

sclevine commented Apr 2, 2014

mr23 commented Apr 2, 2014

ChrisMeierRT commented Apr 4, 2014

gordonwoodhull commented Apr 4, 2014

mr23 commented Apr 5, 2014

gordonwoodhull Apr 18, 2014

Choose a reason for hiding this comment

gordonwoodhull commented Apr 18, 2014

mr23 commented Apr 29, 2014

mr23 commented Jul 27, 2014

gordonwoodhull commented Jul 27, 2014

gordonwoodhull commented Jul 27, 2014

gordonwoodhull commented Sep 29, 2014